feat: let params of internal functions be mutable #3473
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
❗ Your organization is not using the GitHub App Integration. As a result you may experience degraded service beginning May 15th. Please install the Github App Integration for your organization. Read more. @@ Coverage Diff @@
## master #3473 +/- ##
==========================================
+ Coverage 89.30% 89.35% +0.05%
==========================================
Files 84 84
Lines 10792 10777 -15
Branches 2461 2456 -5
==========================================
- Hits 9638 9630 -8
+ Misses 756 751 -5
+ Partials 398 396 -2
... and 9 files with indirect coverage changes 📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
|
please add some tests with complex types: static arrays, dynarrays and structs. |
vyper/semantics/analysis/local.py
Outdated
Comment on lines
177
to
179
| # allow internal function params to be mutable | ||
| location = DataLocation.MEMORY if self.func.is_internal else DataLocation.CALLDATA | ||
| is_immutable = False if self.func.is_internal else True |
There was a problem hiding this comment.
i don't really like repeating branches in general. here i think we can get rid of it with either squashing all into a single ternary like so
Suggested change
| # allow internal function params to be mutable | |
| location = DataLocation.MEMORY if self.func.is_internal else DataLocation.CALLDATA | |
| is_immutable = False if self.func.is_internal else True | |
| # allow internal function params to be mutable | |
| location, is_immutable = (DataLocation.MEMORY, False) if self.func.is_internal else (DataLocation.CALLDATA, True) |
or two assignments per branch
Suggested change
| # allow internal function params to be mutable | |
| location = DataLocation.MEMORY if self.func.is_internal else DataLocation.CALLDATA | |
| is_immutable = False if self.func.is_internal else True | |
| if self.func.is_internal: | |
| location = DataLocation.MEMORY | |
| is_immutable = False | |
| else: | |
| location = DataLocation.CALLDATA | |
| is_immutable = True |
pcaversaccio
added a commit
to pcaversaccio/snekmate
that referenced
this pull request
Aug 14, 2024
### 🕓 Changelog Given that the function parameters of `internal` functions are mutable (as implemented [here](vyperlang/vyper#3473)), this PR refines the internal logic of the `_log2`, `_log10`, `_log256`, `_wad_ln`, and `_wad_exp` functions to align with this behaviour. Additionally, it removes the unnecessary `denominator` variable declaration in the `erc2981` contract and addresses minor formatting issues in code comments. --------- Signed-off-by: Pascal Marco Caversaccio <pascal.caversaccio@hotmail.ch>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What I did
Fix #3449.
How I did it
Update attributes in
VarInfoandVariableRecord.How to verify it
See tests.
Commit message
Description for the changelog
Let params of internal functions be mutable.
Cute Animal Picture